#6 Add php stand dependencies,...

#6 Add php stand dependencies, configuration and ahoy commands

ahoy.test.yml

@@ -38,3 +38,12 @@ commands:
   phpunit:list:groups:
     cmd: ahoy d4d exec vendor/bin/phpunit --configuration /var/www/html/tests/phpunit.xml.dist --list-groups "$@"
     usage: List available test groups of PHP unit tests
+  phpstan:
+    cmd: ahoy d4d exec vendor/bin/phpstan analyze --configuration=/var/www/html/tests/phpstan.neon "$@"
+    usage: PHPStan tests
+  phpstanmodule:
+    cmd: |
+      module=$1
+      shift
+      ahoy d4d exec vendor/bin/phpstan analyze --configuration=/var/www/html/tests/phpstan.neon web/modules/contrib/$module $@
+    usage: PHPStan tests by module

composer.json

@@ -49,11 +49,13 @@
         "lakedrops/docker4drupal": "*",
         "lakedrops/dorgflow": "*",
         "lakedrops/drupal-environment": "*",
+        "mglaman/phpstan-drupal": "^1.1",
         "mikey179/vfsstream": "*",
         "phploc/phploc": "*",
         "phpmd/phpmd": "*",
         "phpspec/prophecy": "*",
         "phpspec/prophecy-phpunit": "*",
+        "phpstan/phpstan-deprecation-rules": "^1.0",
         "phpunit/phpunit": "*",
         "sebastian/phpcpd": "*",
         "squizlabs/php_codesniffer": "*",

src/Handler.php

@@ -120,13 +120,14 @@ class Handler extends BaseHandler {
     $handler->configureProject();
 
     // Copy Test files.
-    foreach (['phpcs.files', 'phpunit.xml.dist'] as $template) {
+    foreach (['phpcs.files', 'phpstan.neon', 'phpunit.xml.dist'] as $template) {
       $rendered = $this->config->render($template, file_get_contents($pluginRoot . '/templates/tests/' . $template));
       file_put_contents('tests/' . $template, $rendered);
     }
 
     // Git Ignore test files.
     $this->gitIgnore('tests/phpcs.files');
+    $this->gitIgnore('tests/phpstan.neon');
     $this->gitIgnore('tests/phpunit.xml.dist');
     $this->gitIgnore('tests/codesniffer_results.txt');
     $this->gitIgnore('tests/checkstyle.xml');

templates/tests/phpstan.neon

+parameters:
+  level: 2
+  reportUnmatchedIgnoredErrors: false
+  customRulesetUsed: true
+  checkMissingIterableValueType: false
+  fileExtensions:
+    - module
+    - theme
+    - profile
+    - install
+  ignoreErrors:
+    - '#Plugin definitions cannot be altered.#'
+includes:
+  - /drupal/vendor/mglaman/phpstan-drupal/extension.neon
+  - /drupal/vendor/phpstan/phpstan-deprecation-rules/rules.neon