Optimize LetsEncrypt and use their role also for HaProxy and Drupal tasks

tasks/buildcerts.yml

+---
+# file: roles/haproxy/tasks/buildcerts.yml
+
+- name: "Create PEM file for HaProxy"
+  assemble:
+    src='/etc/letsencrypt/live/{{ item.domain }}'
+    dest='/etc/haproxy/certs/{{ item.domain }}.pem'
+    regexp='(fullchain)|(privkey)\.pem'
+  with_items: '{{ proxy_certificates_letsencrypt|default([]) }}'

tasks/letsencrypt.yml

----
-# file: roles/haproxy/tasks/letsencrypt.yml
-
-- set_fact: filename='/etc/letsencrypt/live/{{ item.domain }}/cert.pem'
-
-- name: "Check LetsEncrypt Requirement"
-  shell: ls {{ filename }}
-  register: cert_available
-  failed_when: false
-
-- block:
-
-  - name: "Stop HAProxy"
-    service:
-      name='haproxy'
-      state='stopped'
-
-  - name: "Install New Cert"
-    shell: /opt/letsencrypt/letsencrypt-auto certonly -d {{ item.domain }} -d www.{{ item.domain }} --standalone --text --email {{ apache_server_admin|default('admin@paragon-es.de') }} --agree-tos --redirect
-
-  - name: "Start HAProxy"
-    service:
-      name='haproxy'
-      state='started'
-
-  when: cert_available is defined and cert_available.stdout != filename

tasks/main.yml

@@ -2,18 +2,17 @@
 # file: roles/haproxy/tasks/main.yml
 
 - block:
-  - name: "LetsEncrypt Certificates"
-    include: letsencrypt.yml
+  - name: "Install Certs"
+    include: '../../letsencrypt/tasks/cert.yml'
     with_items: '{{ proxy_certificates_letsencrypt|default([]) }}'
 
   - name: "Renew Existing Cert"
     include: '../../letsencrypt/tasks/renew.yml'
 
-  - name: "Create PEM file for HaProxy"
-    shell: cat /etc/letsencrypt/live/{{ item.domain }}/fullchain.pem /etc/letsencrypt/live/{{ item.domain }}/privkey.pem > /etc/haproxy/certs/{{ item.domain }}.pem
-    with_items: '{{ proxy_certificates_letsencrypt|default([]) }}'
-    notify: "Proxy | Restart HAProxy"
+  - name: "Build HaCerts"
+    include: 'buildcerts.yml'
 
+  tags: Certs
   when: '"letsencrypt" not in excluded_roles'
 
 - block:

templates/letsencrypt.ini

+../../letsencrypt/templates/letsencrypt.ini
\ No newline at end of file