Config split commands are included in ahoy, list the module as a requirement or add commands without it

vendor/lakedrops/docker4drupal/ahoy.current.yml defines the commands for interacting with the live database. If config split is not installed on your project, these commands fail with the following output:

There are no commands defined in the "config-split" namespace.

Is it pedantic of me to request config_split module to be listed as a requirement of Lakedrops enabled Drupal projects?

assigned to @jurgenhaas

added Doing label

Thanks @rominronin for reporting this, I fall into this trap before as well. In my case, it was a demo project and I didn't bother too much about it, since all our other projects always use config-split.

I would probably not declare config-split as a dependency because that wouldn't be sufficient. The script also requires that to be enabled and configured, which is not happening automatically.

Instead, I think we could probably make the script smarter and let it skip those commands if config-split isn't available.

I'll take a look at this in the coming days. I'll start by writing versions without config split (just regular config:import or something).

If I have time, I'll see if we can parametrise it somehow.

mentioned in commit composer/plugin/docker4drupal@4c785393

Hi @rominronin I was already on this and added a check whether config-split is enabled. The import only gets executed if that's the case. Please have a look at the linked commit.

A regular config:import that you mentioned should NOT be executed here because there are regular scenarios where a developer downloads the DB from either live or current and then wants to export the config from that DB as they want to extract the changes that have been made upstream. If a config import were executed here, those changes would be lost. If a developer does want to import config from the repository/file-system, then they can call that command manually.

assigned to @rominronin and unassigned @jurgenhaas

mentioned in merge request composer/plugin/docker4drupal!81 (merged)

Closing the issue since it has been released already. If you still want to provide feedback, please re-open.

closed

removed Doing label

reopened

added Documentation label

unassigned @rominronin

EN: This issue hasn't been active for 3 months and will be closed in 2 weeks, if it still doesn't see any updates.

DE: Dieses Issue ist seit 3 Monaten inaktiv und wird in 2 Wochen automatisch geschlossen, falls es sich nicht ändert.

added dormant label

removed dormant label

EN: This issue hasn't been active for 3 months and will be closed in 2 weeks, if it still doesn't see any updates.

DE: Dieses Issue ist seit 3 Monaten inaktiv und wird in 2 Wochen automatisch geschlossen, falls es sich nicht ändert.

added dormant label

removed dormant label

EN: This issue hasn't been active for 3 months and will be closed in 2 weeks, if it still doesn't see any updates.

DE: Dieses Issue ist seit 3 Monaten inaktiv und wird in 2 Wochen automatisch geschlossen, falls es sich nicht ändert.

added dormant label

removed dormant label

EN: This issue hasn't been active for 3 months and will be closed in 2 weeks, if it still doesn't see any updates.

DE: Dieses Issue ist seit 3 Monaten inaktiv und wird in 2 Wochen automatisch geschlossen, falls es sich nicht ändert.

added dormant label

removed dormant label