Skip to content
Snippets Groups Projects
Commit 1742ee96 authored by jurgenhaas's avatar jurgenhaas
Browse files

Add patch to security_review

parent 9b9311cb
No related branches found
No related tags found
1 merge request!349Merging develop into main
Pipeline #1356829 passed
...@@ -173,6 +173,9 @@ ...@@ -173,6 +173,9 @@
"drupal/role_theme_switcher": { "drupal/role_theme_switcher": {
"#3414975 Missing keys": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3414975.diff" "#3414975 Missing keys": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3414975.diff"
}, },
"drupal/security_review": {
"#3488084 NamePassword": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3488084.diff"
},
"drupal/select2": { "drupal/select2": {
"#3211796 Z-Index in modal dialog": "https://www.drupal.org/files/issues/2023-04-18/select2-modal-zindex-mult-form-elem-fix-3211796-17.patch" "#3211796 Z-Index in modal dialog": "https://www.drupal.org/files/issues/2023-04-18/select2-modal-zindex-mult-form-elem-fix-3211796-17.patch"
}, },
......
diff --git a/src/Plugin/SecurityCheck/NamePasswords.php b/src/Plugin/SecurityCheck/NamePasswords.php
index 439017ed957d8f1e53210210b9bcbc8fcfd32bd8..7a992799b4c270253e9753beaff3810b3b4a3fa0 100644
--- a/src/Plugin/SecurityCheck/NamePasswords.php
+++ b/src/Plugin/SecurityCheck/NamePasswords.php
@@ -96,7 +96,7 @@ class NamePasswords extends SecurityCheckBase {
$users = User::loadMultiple($ids);
$findings = [];
foreach ($users as $user) {
- if ($this->userAuth->authenticateAccount($this->userAuth->lookupAccount($user->getDisplayName()), $user->getDisplayName())) {
+ if (($account = $this->userAuth->lookupAccount($user->getAccountName())) && $this->userAuth->authenticateAccount($account, $user->getAccountName())) {
$findings[] = $user->getDisplayName();
}
...@@ -169,6 +169,9 @@ ...@@ -169,6 +169,9 @@
"drupal/role_theme_switcher": { "drupal/role_theme_switcher": {
"#3414975 Missing keys": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3414975.diff" "#3414975 Missing keys": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3414975.diff"
}, },
"drupal/security_review": {
"#3488084 NamePassword": "https://gitlab.lakedrops.com/composer/plugin/drupal-environment/-/raw/main/patches/d10/3488084.diff"
},
"drupal/select2": { "drupal/select2": {
"#3211796 Z-Index in modal dialog": "https://www.drupal.org/files/issues/2023-04-18/select2-modal-zindex-mult-form-elem-fix-3211796-17.patch" "#3211796 Z-Index in modal dialog": "https://www.drupal.org/files/issues/2023-04-18/select2-modal-zindex-mult-form-elem-fix-3211796-17.patch"
}, },
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment