ansible-playbooks/general#85 Linting [skip-ci]

tasks/apache.yml

@@ -3,15 +3,17 @@
 
 - name: Apache Configuration File
   template:
-    src='vhost.conf'
-    dest='/etc/apache2/sites-available/{{ youtrack.domain }}{{ apache_conf_ext }}'
-    owner='root'
-    group='root'
-    mode='664'
+    src: vhost.conf
+    dest: /etc/apache2/sites-available/{{ youtrack.domain }}{{ apache_conf_ext }}
+    owner: root
+    group: root
+    mode: 0664
   notify:
-    - "Apache | Restart Apache"
+    - "Restart Apache"
 
 - name: Apache enable our new site(s)
-  command: a2ensite {{ youtrack.domain }} creates=/etc/apache2/sites-enabled/{{ youtrack.domain }}{{ apache_conf_ext }}
+  command: a2ensite {{ youtrack.domain }}
+  args:
+    creates: /etc/apache2/sites-enabled/{{ youtrack.domain }}{{ apache_conf_ext }}
   notify:
-    - "Apache | Restart Apache"
+    - "Restart Apache"

tasks/install.yml

@@ -2,12 +2,12 @@
 # file: roles/youtrack/tasks/install.yml
 
 - block:
-  - set_fact:
-      apacheLogDir='/var/log/apache2'
-    when: youtrack.jail is not defined
-  - set_fact:
-      apacheLogDir='{{ jailroot }}/{{ youtrack.id }}/var/log/apache2'
-    when: youtrack.jail is defined
+    - set_fact:
+        apacheLogDir: /var/log/apache2
+      when: youtrack.jail is not defined
+    - set_fact:
+        apacheLogDir: '{{ jailroot }}/{{ youtrack.id }}/var/log/apache2'
+      when: youtrack.jail is defined
   tags:
     - always
 

tasks/main.yml

@@ -10,68 +10,69 @@
     - always
 
 - block:
-  - name: Install Certs
-    include_tasks: ../../letsencrypt/tasks/cert.yml
-    with_items: '{{ youtrack_settings|default([]) }}'
-    loop_control:
-      loop_var: domain
-    when: domain.protocol|default("https") == "https" and domain.letsencrypt|default(true)
+    - name: Install Certs
+      include_tasks: ../../letsencrypt/tasks/cert.yml
+      with_items: '{{ youtrack_settings|default([]) }}'
+      loop_control:
+        loop_var: domain
+      when: domain.protocol|default("https") == "https" and domain.letsencrypt|default(true)
 
   when: not excluded_roles or "letsencrypt" not in excluded_roles and groups.proxyserver is not defined
 
 - block:
 
-  - name: Install
-    include_tasks: install.yml
-    with_items: '{{ youtrack_settings|default([]) }}'
-    loop_control:
-      loop_var: youtrack
-    when: limit_youtrack_site is not defined or youtrack.id is not defined or limit_youtrack_site == youtrack.id
+    - name: Install
+      include_tasks: install.yml
+      with_items: '{{ youtrack_settings|default([]) }}'
+      loop_control:
+        loop_var: youtrack
+      when: limit_youtrack_site is not defined or youtrack.id is not defined or limit_youtrack_site == youtrack.id
 
-  - name: Create YouTrack User
-    user:
-      name='youtrack'
-      group='root'
-      home='/home/youtrack'
+    - name: Create YouTrack User
+      user:
+        name: youtrack
+        group: root
+        home: /home/youtrack
 
-  - name: Ensure YouTrack Directory
-    file:
-      path='/var/youtrack'
-      state='directory'
-      owner='root'
-      group='root'
-      mode='755'
+    - name: Ensure YouTrack Directory
+      file:
+        path: /var/youtrack
+        state: directory
+        owner: root
+        group: root
+        mode: 0755
 
-  - name: Create scripts
-    template:
-      src="{{ item.src }}"
-      dest="{{ item.dest }}"
-      owner=root
-      group=root
-      mode='755'
-    with_items:
-      - src: etc_init_d_youtrack
-        dest: /etc/init.d/youtrack
-      - src: bin_youtrack_start.sh
-        dest: /usr/local/bin/youtrack-start.sh
-      - src: bin_youtrack_stop.sh
-        dest: /usr/local/bin/youtrack-stop.sh
-    notify: "Include YouTrack to Boot-List"
+    - name: Create scripts
+      template:
+        src: '{{ item.src }}'
+        dest: '{{ item.dest }}'
+        owner: root
+        group: root
+        mode: 0755
+      with_items:
+        - src: etc_init_d_youtrack
+          dest: /etc/init.d/youtrack
+        - src: bin_youtrack_start.sh
+          dest: /usr/local/bin/youtrack-start.sh
+        - src: bin_youtrack_stop.sh
+          dest: /usr/local/bin/youtrack-stop.sh
+      notify:
+        - Include YouTrack to Boot-List
 
-  - name: Download JAR
-    get_url:
-      url='http://download-ln.jetbrains.com/charisma/youtrack-{{ youtrack_version }}.jar'
-      dest='/var/youtrack/youtrack-{{ youtrack_version }}.jar'
-      owner='youtrack'
-      group='root'
-      mode='644'
+    - name: Download JAR
+      get_url:
+        url: http://download-ln.jetbrains.com/charisma/youtrack-{{ youtrack_version }}.jar
+        dest: /var/youtrack/youtrack-{{ youtrack_version }}.jar
+        owner: youtrack
+        group: root
+        mode: 0644
 
-  - name: Ensure symbolic link
-    file:
-      src='/var/youtrack/youtrack-{{ youtrack_version }}.jar'
-      dest='/var/youtrack/youtrack.jar'
-      owner='root'
-      group='root'
-      state=link
+    - name: Ensure symbolic link
+      file:
+        src: /var/youtrack/youtrack-{{ youtrack_version }}.jar
+        dest: /var/youtrack/youtrack.jar
+        owner: root
+        group: root
+        state: link
 
   when: not excluded_roles or "youtrack" not in excluded_roles