ansible-playbooks/general#85 Linting

tasks/main.yml

@@ -5,16 +5,20 @@
 ---
 # file: roles/vpn/tasks/main.yml
 
-- name: "VPN Role"
-  set_fact: role_vpn_started=true
-  tags: 'always'
+- name: VPN Role
+  set_fact:
+    role_vpn_started: yes
+  tags:
+    - always
 
 - block:
 
-  - import_tasks: 'vpn.yml'
+  - import_tasks: vpn.yml
 
-  - name: 'Remember that this role had been run'
-    set_fact: role_vpn_completed=true
-    tags: 'always'
+  - name: Remember that this role had been run
+    set_fact:
+      role_vpn_completed: yes
+    tags:
+      - always
 
-  when: '"vpn" not in excluded_roles and role_vpn_completed is not defined and vpn is defined and vpn.subnet is defined'
+  when: not excluded_roles or "vpn" not in excluded_roles and role_vpn_completed is not defined and vpn is defined and vpn.subnet is defined

tasks/vpn.yml

 ---
 # file: roles/vpn/tasks/vpn.yml
 
-- name: "Install extra packages"
+- name: Install extra packages
   apt:
     name: '{{ packages }}'
-    state: 'present'
+    state: present
   vars:
     packages:
-      - 'strongswan'
+      - strongswan
 
-- name: "Configure IPSec"
+- name: Configure IPSec
   template:
     src: '{{ item }}.jinja2'
-    dest: '/etc/{{ item }}'
-    owner: 'root'
-    group: 'root'
-    mode: '600'
+    dest: /etc/{{ item }}
+    owner: root
+    group: root
+    mode: 600
   with_items:
-    - 'ipsec.conf'
-    - 'ipsec.secrets'
+    - ipsec.conf
+    - ipsec.secrets