ansible-playbooks/general#85 Linting

tasks/main.yml

 ---
 # file: roles/s3/tasks/main.yml
 
-- name: "S3 Role"
-  set_fact: role_s3_started=true
-  tags: 'always'
+- name: S3 Role
+  set_fact:
+    role_s3_started: yes
+  tags:
+    - always
 
 - block:
 
-  - name: "Apt Keys"
+  - name: Apt Keys
     apt_key:
       url='{{ item }}'
       state='present'
     with_items:
-      - 'http://s3tools.org/repo/deb-all/stable/s3tools.key'
+      - http://s3tools.org/repo/deb-all/stable/s3tools.key
 
-  - name: "Apt Repositories"
+  - name: Apt Repositories
     apt_repository:
       repo='{{ item }}'
       state='present'
       mode='644'
     with_items:
-      - 'deb http://s3tools.org/repo/deb-all stable/'
+      - deb http://s3tools.org/repo/deb-all stable/
 
-  - name: "Install more packages"
+  - name: Install more packages
     apt:
       pkg='{{ packages }}'
       state='present'
       update_cache=yes
     vars:
       packages:
-        - 's3cmd'
+        - s3cmd
 
-  - name: "Ensure directory"
+  - name: Ensure directory
     file:
       dest='/opt/s3/'
       owner='root'
@@ -39,11 +41,11 @@
       state='directory'
       mode='775'
 
-  - name: "Copy files"
+  - name: Copy files
     template:
       src='{{ item }}'
       dest='/opt/s3/{{ item }}'
     with_items:
-      - 's3.cfg'
+      - s3.cfg
 
-  when: '"s3" not in excluded_roles'
+  when: not excluded_roles or "s3" not in excluded_roles