ansible-playbooks/general#85 Linting

handlers/main.yml

 ---
 # file: roles/heartbeat/handlers/main.yml
 
-- name: "Add Heartbeat to Boot-List"
+- name: Add Heartbeat to Boot-List
   systemd:
-    name: 'heartbeat-elastic'
-    state: 'started'
+    name: heartbeat-elastic
+    state: started
     daemon_reload: yes
     enabled: yes
 
-- name: "Start Heartbeat"
+- name: Start Heartbeat
   service:
-    name: 'heartbeat-elastic'
-    state: 'started'
+    name: heartbeat-elastic
+    state: started
 
-- name: "Restart Heartbeat"
+- name: Restart Heartbeat
   service:
-    name: 'heartbeat-elastic'
-    state: 'restarted'
+    name: heartbeat-elastic
+    state: restarted

tasks/config.yml

 ---
 # file: roles/heartbeat/tasks/config.yml
 
-- name: "Ensure config directories"
+- name: Ensure config directories
   file:
-    path: '/etc/heartbeat/monitors.d'
-    state: 'directory'
+    path: /etc/heartbeat/monitors.d
+    state: directory
 
-- name: "Configure Heartbeat"
+- name: Configure Heartbeat
   template:
-    src: 'heartbeat.yml'
-    dest: '/etc/heartbeat/heartbeat.yml'
-    owner: 'root'
-    group: 'root'
-    mode: '600'
+    src: heartbeat.yml
+    dest: /etc/heartbeat/heartbeat.yml
+    owner: root
+    group: root
+    mode: 600
   notify:
   - "Restart Heartbeat"
 
-- name: "Copy all monitor configurations"
+- name: Copy all monitor configurations
   copy:
     src: '{{ inventory_dir }}/files/heartbeat/'
-    dest: '/etc/heartbeat/monitors.d/'
-    mode: '600'
+    dest: /etc/heartbeat/monitors.d/
+    mode: 600

tasks/install.yml

 ---
 # file: roles/heartbeat/tasks/install.yml
 
-- name: "Apt Key"
+- name: Apt Key
   apt_key:
-    url: 'https://artifacts.elastic.co/GPG-KEY-elasticsearch'
-    state: 'present'
+    url: https://artifacts.elastic.co/GPG-KEY-elasticsearch
+    state: present
 
-- name: "Apt Repository"
+- name: Apt Repository
   apt_repository:
-    repo: 'deb https://artifacts.elastic.co/packages/6.x/apt stable main'
-    state: 'present'
-    mode: '644'
+    repo: deb https://artifacts.elastic.co/packages/6.x/apt stable main
+    state: present
+    mode: 644
 
-- name: "Install Heartbeat"
+- name: Install Heartbeat
   apt:
-    pkg: 'heartbeat-elastic'
-    state: 'present'
+    pkg: heartbeat-elastic
+    state: present
     update_cache: yes
   notify:
   - "Add Heartbeat to Boot-List"

tasks/main.yml

 ---
 # file: roles/heartbeat/tasks/main.yml
 
-- name: "Heartbeat Role"
-  set_fact: role_heartbeat_started=true
-  tags: 'always'
+- name: Heartbeat Role
+  set_fact:
+    role_heartbeat_started: yes
+  tags:
+    - always
 
 - block:
 
@@ -11,4 +13,4 @@
 
   - include_tasks: config.yml
 
-  when: '"heartbeat" not in excluded_roles'
+  when: not excluded_roles or "heartbeat" not in excluded_roles

templates/heartbeat.yml

@@ -19,7 +19,7 @@ heartbeat.config.monitors:
 heartbeat.monitors:
 - type: http
   urls: ["http://localhost:9200"]
-  schedule: '@every 10s'
+  schedule: @every 10s
 
 #==================== Elasticsearch template setting ==========================