ansible-playbooks/general#72 Always use import_tasks or include_tasks instead of just include

tasks/main.yml

@@ -7,8 +7,8 @@
 
 - block:
 
-  - include: install.yml
-  - include: configure.yml
+  - import_tasks: install.yml
+  - import_tasks: configure.yml
     tags: 'Config'
 
   when: '"haproxy" not in excluded_roles'
@@ -16,20 +16,20 @@
 - block:
 
   - name: "Install Certs"
-    include: '../../letsencrypt/tasks/cert.yml'
+    include_tasks: '../../letsencrypt/tasks/cert.yml'
     with_items: '{{ proxy_certificates|default([]) }}'
     loop_control:
       loop_var: domain
     when: domain.letsencrypt|default(false) and domain.active|default(true)
 
   - name: "Renew Existing Cert"
-    include: '../../letsencrypt/tasks/renew.yml'
+    import_tasks: '../../letsencrypt/tasks/renew.yml'
 
   - name: "Build HaProxy Certs"
-    include: 'buildcerts.yml'
+    import_tasks: 'buildcerts.yml'
 
   tags: 'Certs'
   when: 'proxy_active and "letsencrypt" not in excluded_roles'
 
-- include_tasks: 'proxypool.yml'
+- import_tasks: 'proxypool.yml'
   tags: 'Certs'

tasks/proxypool.yml

 ---
 # file: roles/haproxy/tasks/proxypool.yml
 
-- name: "Set directory permissions to current user"
-  file:
-    path: '/etc/letsencrypt'
-    owner: '{{ ansible_env.SUDO_USER }}'
-    recurse: yes
-  tags: 'Certs'
-  when: 'proxy_active is defined and proxy_active and "letsencrypt" not in excluded_roles'
+- block:
 
-- name: "Pull Certs from active Proxy"
-  include: 'pullcerts.yml'
-  tags: 'Certs'
-  when: 'proxy_active is defined and not proxy_active and "letsencrypt" not in excluded_roles'
+  - name: "Set directory permissions to current user"
+    file:
+      path: '/etc/letsencrypt'
+      owner: '{{ ansible_env.SUDO_USER }}'
+      recurse: yes
+    when: 'proxy_active is defined and proxy_active and "letsencrypt" not in excluded_roles'
+
+  - name: "Pull Certs from active Proxy"
+    import_tasks: 'pullcerts.yml'
+    when: 'proxy_active is defined and not proxy_active and "letsencrypt" not in excluded_roles'
+
+  - name: "Set directory permissions to root"
+    file:
+      path: '/etc/letsencrypt'
+      owner: 'root'
+      recurse: yes
+    when: 'proxy_active is defined and proxy_active and "letsencrypt" not in excluded_roles'
 
-- name: "Set directory permissions to root"
-  file:
-    path: '/etc/letsencrypt'
-    owner: 'root'
-    recurse: yes
   tags: 'Certs'
-  when: 'proxy_active is defined and proxy_active and "letsencrypt" not in excluded_roles'