ansible-playbooks/general#85 Linting [skip-ci]

handlers/main.yml

@@ -11,12 +11,12 @@
 
 - name: Add ElastAlert to Boot-List
   systemd:
-    name='elastalert'
-    state='started'
-    daemon_reload=yes
-    enabled=yes
+    name: elastalert
+    state: started
+    daemon_reload: yes
+    enabled: yes
 
 - name: Restart ElastAlert
   service:
-    name='elastalert'
-    state='restarted'
+    name: elastalert
+    state: restarted

tasks/install.yml

@@ -15,16 +15,16 @@
 
 - name: Start Script
   template:
-    src='etc_init_d_elastalert'
-    dest='/etc/init.d/elastalert'
-    owner='root'
-    group='root'
-    mode='755'
+    src: etc_init_d_elastalert
+    dest: /etc/init.d/elastalert
+    owner: root
+    group: root
+    mode: 0755
 
 - name: Install PIP Components
   pip:
-    name='{{ packages }}'
-    state='latest'
+    name: '{{ packages }}'
+    state: latest
   vars:
     packages:
       - pip
@@ -35,25 +35,25 @@
 
 - name: Install PIP Requirements
   pip:
-    requirements='/opt/elastalert/requirements.txt'
-    state='latest'
+    requirements: /opt/elastalert/requirements.txt
+    state: latest
   notify:
     - "Restart ElastAlert"
 
 - name: Ensure Rules Directory
   file:
-    path='/opt/elastalert/my_rules'
-    state='directory'
-    owner='root'
-    group='root'
-    mode='755'
+    path: /opt/elastalert/my_rules
+    state: directory
+    owner: root
+    group: root
+    mode: 0755
 
 - name: Configuration
   template:
-    src='config.yaml'
-    dest='/opt/elastalert/config.yaml'
-    owner='root'
-    group='root'
-    mode='644'
+    src: config.yaml
+    dest: /opt/elastalert/config.yaml
+    owner: root
+    group: root
+    mode: 0644
   notify:
     - "Restart ElastAlert"

tasks/main.yml

@@ -21,4 +21,4 @@
       loop_var: drupal_host
 
   #when: not excluded_roles or "elastalert" not in excluded_roles
-  when: false
+  when: no

tasks/rules.drupal.yml

@@ -2,19 +2,19 @@
 # file: roles/elastalert/tasks/rules.drupal.yml
 
 - block:
-  - set_fact:
-      hostname='{{ drupal_host.0 }}'
-      filename='{{ drupal_host.1 }}'
-  - name: Rule for Drupal
-    template:
-      src='{{ filename }}.yaml'
-      dest='/opt/elastalert/my_rules/{{ filename }}.{{ item.1.domain }}.yaml'
-      owner='root'
-      group='root'
-      mode='644'
-    with_subelements:
-      - {{ hostvars[hostname].drupal_settings }}
-      - domains
-    when: item.1.elastalert is defined
+    - set_fact:
+        hostname: '{{ drupal_host.0 }}'
+        filename: '{{ drupal_host.1 }}'
+    - name: Rule for Drupal
+      template:
+        src: '{{ filename }}.yaml'
+        dest: /opt/elastalert/my_rules/{{ filename }}.{{ item.1.domain }}.yaml
+        owner: root
+        group: root
+        mode: 0644
+      with_subelements:
+        - {{ hostvars[hostname].drupal_settings }}
+        - domains
+      when: item.1.elastalert is defined
   tags:
     - Rules

tasks/rules.yml

@@ -3,11 +3,11 @@
 
 - name: Rules
   template:
-    src='rule.yaml'
-    dest='/opt/elastalert/my_rules/{{ item.key }}.yaml'
-    owner='root'
-    group='root'
-    mode='644'
+    src: rule.yaml
+    dest: /opt/elastalert/my_rules/{{ item.key }}.yaml
+    owner: root
+    group: root
+    mode: 0644
   with_items: '{{ elastalerts|default([]) }}'
   tags:
     - Rules