ansible-playbooks/general#85 Linting

defaults/main.yml

 docker_pip_packages: []
 docker_subnet: false
-docker_compose_version: '1.17.1'
+docker_compose_version: 1.17.1

handlers/main.yml

 ---
 # file: roles/docker/handlers/main.yml
 
-- name: "Add Docker to Boot-List"
+- name: Add Docker to Boot-List
   systemd:
-    name: 'docker'
-    state: 'started'
+    name: docker
+    state: started
     enabled: yes
     daemon_reload: yes
 
-- name: "Start Docker"
+- name: Start Docker
   service:
-    name: 'docker'
-    state: 'started'
+    name: docker
+    state: started

tasks/install.yml

 ---
 # file: roles/docker/tasks/install.yml
 
-- name: "Apt Key"
+- name: Apt Key
   apt_key:
-    url: 'https://download.docker.com/linux/ubuntu/gpg'
-    state: 'present'
+    url: https://download.docker.com/linux/ubuntu/gpg
+    state: present
 
-- name: "Apt Repository"
+- name: Apt Repository
   apt_repository:
-    repo: 'deb [arch=amd64] https://download.docker.com/linux/ubuntu {{ ansible_distribution_release }} stable'
-    state: 'present'
-    mode: '644'
+    repo: deb [arch=amd64] https://download.docker.com/linux/ubuntu {{ ansible_distribution_release }} stable
+    state: present
+    mode: 644
 
-- name: "Install Docker Engine"
+- name: Install Docker Engine
   apt:
-    pkg: 'docker-ce'
-    state: 'present'
+    pkg: docker-ce
+    state: present
     update_cache: yes
   notify:
     - "Add Docker to Boot-List"
     - "Start Docker"
 
-- name: "Download Docker Compose"
+- name: Download Docker Compose
   get_url:
-    url: 'https://github.com/docker/compose/releases/download/{{ docker_compose_version }}/docker-compose-{{ ansible_system }}-{{ ansible_architecture }}'
-    dest: '/usr/local/bin/docker-compose'
-    mode: '755'
+    url: https://github.com/docker/compose/releases/download/{{ docker_compose_version }}/docker-compose-{{ ansible_system }}-{{ ansible_architecture }}
+    dest: /usr/local/bin/docker-compose
+    mode: 755
 
-- name: "Configure delayed startup of Docker engine"
+- name: Configure delayed startup of Docker engine
   lineinfile:
-    dest: '/etc/init/docker.conf'
-    insertafter: 'pre-start script'
-    regexp: 'sleep 10'
-    line: 'sleep 10'
+    dest: /etc/init/docker.conf
+    insertafter: pre-start script
+    regexp: sleep 10
+    line: sleep 10
   when: false
 
-- name: "Configure Docker Daemon"
+- name: Configure Docker Daemon
   template:
-    src: 'daemon.json.jinja2'
-    dest: '/etc/docker/daemon.json'
-    owner: 'root'
-    group: 'root'
-    mode: '600'
+    src: daemon.json.jinja2
+    dest: /etc/docker/daemon.json
+    owner: root
+    group: root
+    mode: 600
 
-- name: "Install Python Dependencies"
+- name: Install Python Dependencies
   pip:
     name: '{{ docker_pip_packages }}'
 
-- name: "Ensure group 82"
+- name: Ensure group 82
   group:
-    name: 'www-docker'
+    name: www-docker
     gid: 82
-    state: 'present'
+    state: present
 
-- name: "Add local user to group 82"
+- name: Add local user to group 82
   user:
     name: "{{ lookup('env','USER') }}"
-    groups: 'www-docker,docker'
-    append: 'yes'
+    groups: www-docker,docker
+    append: yes
 
-- name: "Fish Config"
+- name: Fish Config
   copy:
-    src: 'docker-compose.fish'
-    dest: '/etc/fish/conf.d/docker-compose.fish'
-    owner: 'root'
-    group: 'root'
-    mode: '644'
+    src: docker-compose.fish
+    dest: /etc/fish/conf.d/docker-compose.fish
+    owner: root
+    group: root
+    mode: 644
 
-- name: "Add iptables chains"
+- name: Add iptables chains
   iptables:
     chain: '{{ item }}'
   with_items:
-    - 'DOCKER'
-    #- 'DOCKER-ISOLATION'
+    - DOCKER
+    #- DOCKER-ISOLATION
   when: groups.proxyserver is not defined

tasks/main.yml

 ---
 # file: roles/docker/tasks/main.yml
 
-- name: "Docker Role"
-  set_fact: role_docker_started=true
-  tags: 'always'
+- name: Docker Role
+  set_fact:
+    role_docker_started: yes
+  tags:
+    - always
 
 - block:
 
   - import_tasks: install.yml
 
-  when: '"docker" not in excluded_roles'
+  when: not excluded_roles or "docker" not in excluded_roles