ansible-playbooks/general#85 Linting

defaults/main.yml

@@ -8,7 +8,7 @@ composer_home_owner: root
 composer_home_group: root
 composer_global_packages: {}
 composer_global_packages_base: {}
-#  hirak/prestissimo: '^0.3'
+#  hirak/prestissimo: ^0.3
 # TODO: Not possible for PHP 5, so make groups vars when Ansible 2.3 is out
 
 # Visit https://github.com/settings/applications

tasks/auth_json.yml

 ---
 
-- name: "Ensure Composer Home for root"
+- name: Ensure Composer Home for root
   file:
-    path: '/root/.composer'
-    state: 'directory'
+    path: /root/.composer
+    state: directory
 
-- name: "Configure github oauth token"
+- name: Configure github oauth token
   template:
     src: ".composer/auth.json.j2"
     dest: "{{ item }}/auth.json"
   with_items:
-    - '/root/.composer'
-    - '{{ composer_home_path }}'
+    - /root/.composer
+    - {{ composer_home_path }}
   when: composer_github_oauth != false or composer_http_basic != false

tasks/configure.yml

 ---
 
-- name: "Create composer home path"
+- name: Create composer home path
   file:
     path: '{{ composer_home_path }}'
-    state: 'directory'
+    state: directory
     owner: '{{ composer_home_owner }}'
     group: '{{ composer_home_group }}'
 
-- name: "Configure composer home path"
+- name: Configure composer home path
   copy:
-    dest: '/etc/profile.d/composer-home.sh'
-    mode: '755'
+    dest: /etc/profile.d/composer-home.sh
+    mode: 755
     content: "export COMPOSER_HOME={{ composer_home_path}}\n"
   when: composer_home_path is defined
 
-- name: "Configure composer path environment"
+- name: Configure composer path environment
   copy:
-    dest: '/etc/profile.d/composer-path.sh'
-    mode: '755'
+    dest: /etc/profile.d/composer-path.sh
+    mode: 755
     content: "export PATH=${PATH}:{{ composer_home_path }}/vendor/bin\n"
 
-- name: "Disable XDebug for CLI"
+- name: Disable XDebug for CLI
   command: '{{ (php_version_main|default("7") == "7") | ternary("phpdismod", "php5dismod") }} -s cli xdebug'
-  tags: 'update'
+  tags:
+    - update
 
-- name: "Global Config Composer"
+- name: Global Config Composer
   shell: env COMPOSER_HOME={{ composer_home_path }}
          composer global config --global {{ item }}
   with_items: '{{ composer_config|default([]) }}'
 
-- name: "Global require packages"
+- name: Global require packages
   shell: env COMPOSER_HOME={{ composer_home_path }}
          composer global require {{ item.key }}:{{ item.value }} --no-progress
          creates={{ composer_home_path }}/vendor/{{ item.key }}
   with_dict: '{{ composer_global_packages|combine(composer_global_packages_base) }}'
   when: composer_global_packages|combine(composer_global_packages_base)|length > 0
-  tags: 'update'
+  tags:
+    - update

tasks/install.yml

 ---
 
-- name: "Download and install Composer into the target directory."
+- name: Download and install Composer into the target directory.
   get_url:
-    url: 'https://getcomposer.org/composer.phar'
+    url: https://getcomposer.org/composer.phar
     timeout: '{{ composer_get_timeout|default(omit) }}'
     dest: '{{ composer_path }}'
-    mode: '755'
+    mode: 755

tasks/main.yml

@@ -3,10 +3,12 @@
 - block:
   - import_tasks: install.yml
   - import_tasks: test.yml
-    tags: 'update'
+    tags:
+      - update
   - import_tasks: configure.yml
   - import_tasks: auth_json.yml
   - import_tasks: update.yml
     when: composer_update == true
-    tags: 'update'
-  when: '"composer" not in excluded_roles'
+    tags:
+      - update
+  when: not excluded_roles or "composer" not in excluded_roles

tasks/test.yml

 ---
 
-- name: "Get stat of composer file"
+- name: Get stat of composer file
   stat:
     path: "{{ composer_path }}"
   register: composer_stat
 
-- name: "Test if composer file exist"
+- name: Test if composer file exist
   fail:
     msg: "{{ composer_path }} doesn't exist"
   when: composer_stat.stat.exists == false

tasks/update.yml

 ---
 
-- name: "Get date for composer update"
+- name: Get date for composer update
   shell: "date --date='{{ composer_update_day }} days ago' +'%s'"
   register: composer_date
   changed_when: False
 
-- name: "Update composer if necessary"
+- name: Update composer if necessary
   shell: "{{ composer_path }} selfupdate"
   when: composer_date.stdout|int > composer_stat.stat.mtime|int
 
-- name: ""
+- name:
   stat:
     path: '{{ composer_home_path }}/composer.json'
   register: composer_file
 
-- name: "Update Composer Packages"
+- name: Update Composer Packages
   shell: env COMPOSER_HOME={{ composer_home_path }}
          composer global update
   when: composer_file.stat.exists is defined and composer_file.stat.exists

tests/Makefile

-test_ubuntu-14.04:
-	VM_BOX='ubuntu/trusty64' vagrant up --provision
-	VM_BOX='ubuntu/trusty64' vagrant provision
-	VM_BOX='ubuntu/trusty64' vagrant destroy -f
-
-test_ubuntu-12.04:
-	VM_BOX='hashicorp/precise64' vagrant up --provision
-	VM_BOX='hashicorp/precise64' vagrant provision
-	VM_BOX='hashicorp/precise64' vagrant destroy -f
-
-test_debian-7.5:
-	VM_BOX='puphpet/debian75-x64' vagrant up --provision
-	VM_BOX='puphpet/debian75-x64' vagrant provision
-	VM_BOX='puphpet/debian75-x64' vagrant destroy -f

tests/Vagrantfile

-$VM_BOX = ENV.has_key?('VM_BOX') ? ENV['VM_BOX'] : 'ubuntu/trusty64'
-
-Vagrant.configure('2') do |config|
-  config.vm.box = $VM_BOX
-
-  config.vm.provision :ansible do |ansible|
-    ansible.playbook = 'playbook.yml'
-    ansible.extra_vars = { ansible_ssh_user: 'vagrant', vagrant: true }
-
-    ansible.verbose = 'v'
-  end
-end

tests/inventory

-localhost

tests/playbook.yml

----
-
-- hosts: all
-  become: true
-  vars:
-    composer_github_oauth: f03401aae1e276abb073f987c08a32410f462e73
-    composer_http_basic:
-        repo.magento.com:
-            username: 52fe41da9d8caa70538244c10f367d0a
-            password: 238fe32d374a2573c4527bd45a7e6f54
-  roles:
-    - { role: common,                      tags: 'apt'      }
-    - { role: ../../ansible-role-composer, tags: 'composer' }

tests/roles/common/tasks/main.yml

----
-
-- name: Update Apt cache
-  apt:
-    update_cache=yes
-    cache_valid_time=3600
-
-- name: Install php packages
-  apt:
-    pkg=php5
-    state=present