ansible-playbooks/general#85 Linting [skip-ci]

defaults/main.yml

+---
+
 tunnel_user_name: systunnel

tasks/main.yml

@@ -3,54 +3,54 @@
 
 - name: Common Connect Role
   set_fact:
-    role_commonconnect_started: true
+    role_commonconnect_started: yes
   tags:
     - always
 
 - block:
 
-  - name: Create The /etc/hosts File
-    template:
-      src: etc_hosts.jinja2
-      dest: /etc/hosts
-      owner: root
-      group: root
-      mode: 0644
-
-  - name: Copy SSH Config For Server-To-Server Communication For Admins
-    template:
-      src: ssh_config.jinja2
-      dest: /home/{{ item }}/.ssh/config
-      owner: '{{ item }}'
-      group: root
-      mode: 0644
-    with_flattened:
-      - {{ admins|default([]) }}
-      - {{ jailusers|default([]) }}
-
-  - block:
-
-    - name: Read available variable cache files
-      shell: ls ~/.ansible/hostvars
-      become: no
-      register: variable_files
-      failed_when: false
-      changed_when: false
-      ignore_errors: true
+    - name: Create The /etc/hosts File
+      template:
+        src: etc_hosts.jinja2
+        dest: /etc/hosts
+        owner: root
+        group: root
+        mode: 0644
+
+    - name: Copy SSH Config For Server-To-Server Communication For Admins
+      template:
+        src: ssh_config.jinja2
+        dest: /home/{{ item }}/.ssh/config
+        owner: '{{ item }}'
+        group: root
+        mode: 0644
+      with_flattened:
+        - '{{ admins|default([]) }}'
+        - '{{ jailusers|default([]) }}'
+
+    - block:
+
+        - name: Read available variable cache files
+          shell: ls ~/.ansible/hostvars
+          become: no
+          register: variable_files
+          failed_when: no
+          changed_when: no
+          ignore_errors: yes
+          tags:
+            - always
+
+        - include_tasks: more.yml
+          with_items: '{{ variable_files.stdout_lines|default([]) }}'
+          loop_control:
+            loop_var: inventory_name
+
+      when: lookup('pipe','hostname') == inventory_hostname
+
+    - name: Remember that this role had been run
+      set_fact:
+        role_commonconnect_completed: yes
       tags:
         - always
 
-    - include_tasks: more.yml
-      with_items: '{{ variable_files.stdout_lines|default([]) }}'
-      loop_control:
-        loop_var: inventory_name
-
-    when: lookup('pipe','hostname') == inventory_hostname
-
-  - name: Remember that this role had been run
-    set_fact:
-      role_commonconnect_completed: true
-    tags:
-      - always
-
   when: not excluded_roles or "commonconnect" not in excluded_roles and role_commonconnect_completed is not defined