Some bugs and deprecated code
I'm testing this app at the moment, and I'm finding a few bugs and some deprecated code. I've made a fork where I'm uploading bug-fixes and other code improvements, but do you want me to also create separate issues for everything here?
Here is what I've got so far:
-
The app wasn't able to read any of the JSON coming from Drupal. I eventually found that this was caused by BOMs appearing in the beginning if the data, so I had to filter these out: https://gitlab.paragon-es.de/reswild/drupal/commit/cf4ea58e02aea0afa72e5b96337169ec5f9ff3ad
-
Deleting files wasn't working properly because of a bug in the fileDeleteCheck function: https://gitlab.paragon-es.de/reswild/drupal/commit/8ba68796e96a274dc082592c89fc213a94a8a374
-
When I did a test with ownCloud 9, I had to replace the deprecated OC_Util::isCallRegistered() method: https://gitlab.paragon-es.de/reswild/drupal/commit/fe7bcdf5ad3735181ff5b663ab009fb11e15d1e8
-
In ownCloud 8.2, I'm getting my log filled up with large amounts of the following error messages (and I haven't had time to look into it yet): Error PHP Cannot modify header information - headers already sent by (output started at /var/www/owncloud/lib/private/files/view.php:378) at /var/www/owncloud/lib/private/response.php#212 Error PHP Cannot modify header information - headers already sent by (output started at /var/www/owncloud/lib/private/files/view.php:378) at /var/www/owncloud/lib/private/response.php#54 Error PHP Cannot modify header information - headers already sent by (output started at /var/www/owncloud/lib/private/files/view.php:378) at /var/www/owncloud/lib/private/response.php#131