Drupal 8 SASS Theme issueshttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues2020-12-29T10:27:49Zhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/10Optimize update process2020-12-29T10:27:49ZJürgen Haasjuergen.haas@lakedrops.comOptimize update processBetter determination of a theme name and writing back settings to composer.jsonBetter determination of a theme name and writing back settings to composer.jsonhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/9themename.libraries.yml needs more cleverness2020-12-29T10:27:49ZJürgen Haasjuergen.haas@lakedrops.comthemename.libraries.yml needs more clevernessThe JS libraries content may change, so we need to update that but still keep the custom changes as well.
While on it, let's also sort the javascript files alphabetically.The JS libraries content may change, so we need to update that but still keep the custom changes as well.
While on it, let's also sort the javascript files alphabetically.https://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/8Overwrite mode overwrites too much2020-12-29T10:27:49ZJürgen Haasjuergen.haas@lakedrops.comOverwrite mode overwrites too muchIt also overwrites files from the base theme, which shouldn't be the case.It also overwrites files from the base theme, which shouldn't be the case.https://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/3Include StyleLint2020-12-29T10:27:48ZJürgen Haasjuergen.haas@lakedrops.comInclude StyleLintSee http://stylelint.io/See http://stylelint.io/https://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/11Implement support for Bootstrap 4 and Gulp 42020-12-16T11:37:14ZJürgen Haasjuergen.haas@lakedrops.comImplement support for Bootstrap 4 and Gulp 4Felix HäberleFelix Häberlehttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/1Finalize first version and provide README2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comFinalize first version and provide READMEJürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.comhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/2Automate NPM install2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comAutomate NPM installWhen the theme gets installed or updated through composer, then we want to make sure that npm and bower get updated too. Add this to composer.json:
```json
"require": {
"eloquent/composer-npm-bridge": "^3"
},
```When the theme gets installed or updated through composer, then we want to make sure that npm and bower get updated too. Add this to composer.json:
```json
"require": {
"eloquent/composer-npm-bridge": "^3"
},
```Jürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.comhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/4Move bower assets to project2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comMove bower assets to projectWhen using the [Project Template](https://gitlab.paragon-es.de/lakedrops/d8-project) there will now be the bower assets being [installed globally](https://gitlab.paragon-es.de/lakedrops/d8-project/issues/7) and we rather use those than o...When using the [Project Template](https://gitlab.paragon-es.de/lakedrops/d8-project) there will now be the bower assets being [installed globally](https://gitlab.paragon-es.de/lakedrops/d8-project/issues/7) and we rather use those than our own.Jürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.comhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/5Build gulp file more dynamically2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comBuild gulp file more dynamicallyThere is currently a [problem with composer and plugins](https://github.com/hiqdev/asset-packagist/issues/20), which may lead to bower-assets being installed in the wrong place originally. This issue was triggered by that problem but has...There is currently a [problem with composer and plugins](https://github.com/hiqdev/asset-packagist/issues/20), which may lead to bower-assets being installed in the wrong place originally. This issue was triggered by that problem but has a more general approach as well.
Let's build the gulpfile.js fully dynamically such that it will reflect the real installation context.Jürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.comhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/6Ignore assets and templates files2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comIgnore assets and templates files- Fonts from bower components
- gulpfile
and maybe even more- Fonts from bower components
- gulpfile
and maybe even moreJürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.comhttps://gitlab.lakedrops.com/composer/plugin/drupal-8-sass-theme/-/issues/7Improve theme update script2017-03-27T17:01:33ZJürgen Haasjuergen.haas@lakedrops.comImprove theme update scriptWhen running `composer drupal-theme-update` ~~we don't seem to get the composer object properly and hence, the variables are not defined~~. Turned out that was not the case. But here is the list of what still needs to be done:
- [x] Re...When running `composer drupal-theme-update` ~~we don't seem to get the composer object properly and hence, the variables are not defined~~. Turned out that was not the case. But here is the list of what still needs to be done:
- [x] Re-enable gulp for composer install because that's required on live sites, check the sanity of the system first
- [x] Re-build theme, including files that normally don't get overwritten
- [x] Reset assets (node, bower, fonts, etc.) so that we get a clean state
- [x] Add .gitkeep to .gitignore (is that the way to use this?)
- [x] Using subdir `img` or `images`?
- [x] Create `_default_variables.scss` and `_bower_assets.scss` only if required
- [x] Post install may throw exception: `npm WARN lifecycle undefined~postinstall: cannot run in wd %s %s (wd=%s) undefined find node_modules/ -name '*.info' -type f -delete /jails/lakedrops/var/www/web/themes/custom/lakedrops`
- [x] Run bower only if json file is available: `bower ENOENT No bower.json present [Exception] Bower returned a non-zero exit code`
Jürgen Haasjuergen.haas@lakedrops.comJürgen Haasjuergen.haas@lakedrops.com