From 7075fad32f33ecb8267ff5daccb0702252e6830a Mon Sep 17 00:00:00 2001
From: jurgenhaas <juergen@paragon-es.de>
Date: Tue, 19 Mar 2019 10:53:01 +0100
Subject: [PATCH] Improve handling of limit_site argument

---
 tasks/initjailusers.yml |  8 ++++----
 tasks/jailkit.yml       | 18 +++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/tasks/initjailusers.yml b/tasks/initjailusers.yml
index bdb5349..cadf09f 100644
--- a/tasks/initjailusers.yml
+++ b/tasks/initjailusers.yml
@@ -20,7 +20,7 @@
        '.ssh',
        '.zshrc'
       ]
-  when: item.0.jail is defined and username in item.0.jail.users and (limit_site is not defined or item.0.id is not defined or limit_site == item.0.id)
+  when: item.0.jail is defined and username in item.0.jail.users and (limit_site is not defined or limit_site == 'False' or item.0.id is not defined or limit_site == item.0.id)
   ignore_errors: true
   tags: 'JailUserInit'
 
@@ -30,7 +30,7 @@
     groups='{{ item.jail.name }}'
     append=yes
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (username in item.jail.users or username in admins) and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (username in item.jail.users or username in admins) and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
   tags: 'SetPermissions'
 
 - name: "Add User To Jail /etc/passwd"
@@ -40,7 +40,7 @@
     regexp='^{{ username }}:'
     line='{{ username }}:x:{{ userid.stdout }}:0::/var/www{{ item.webRoot|default("") }}:/bin/bash'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and username in item.jail.users and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and username in item.jail.users and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
   tags: 'SetPermissions'
 
 - name: "File Modes and Ownership"
@@ -51,7 +51,7 @@
     recurse=yes
     follow=no
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (username in item.jail.users or username in admins) and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (username in item.jail.users or username in admins) and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
   tags:
     - 'JailUserInit'
     - 'SetPermissions'
diff --git a/tasks/jailkit.yml b/tasks/jailkit.yml
index 41bdf92..b745ce9 100644
--- a/tasks/jailkit.yml
+++ b/tasks/jailkit.yml
@@ -64,14 +64,14 @@
     mode='755'
   register: jail_available
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
 
 - name: "Init Jails"
   include_tasks: initjail.yml
   with_items: '{{ drupal_settings|default([]) }}'
   loop_control:
     loop_var: drupal
-  when: drupal.jail is defined and (jail_available is changed or jailsite_init_force) and (limit_site is not defined or drupal.id is not defined or limit_site == drupal.id)
+  when: drupal.jail is defined and (jail_available is changed or jailsite_init_force) and (limit_site is not defined or limit_site == 'False' or drupal.id is not defined or limit_site == drupal.id)
 
 - name: "Ensure tmp Directory"
   file:
@@ -81,7 +81,7 @@
     group='root'
     mode='777'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
 
 - name: "Ensure var and log Directory"
   file:
@@ -91,7 +91,7 @@
     group='root'
     mode='755'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
 
 - name: "Ensure Apache Log Directory"
   file:
@@ -101,7 +101,7 @@
     group='{{ item.jail.name }}'
     mode='755'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
 
 - name: "Install logrotate script"
   template:
@@ -111,7 +111,7 @@
     group='root'
     mode='644'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
   tags: 'logrotate'
 
 - name: "Ensure Apache Web Directory"
@@ -122,7 +122,7 @@
     group='{{ item.jail.name }}'
     mode='755'
   with_items: '{{ drupal_settings|default([]) }}'
-  when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+  when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
 
 - block:
 
@@ -139,7 +139,7 @@
       group='root'
       mode='644'
     with_items: '{{ drupal_settings|default([]) }}'
-    when: item.jail is defined and (limit_site is not defined or item.id is not defined or limit_site == item.id)
+    when: item.jail is defined and (limit_site is not defined or limit_site == 'False' or item.id is not defined or limit_site == item.id)
     notify: "Restart PHP-FPM"
 
   when: php_fpm
@@ -192,7 +192,7 @@
   with_items: '{{ drupal_settings|default([]) }}'
   loop_control:
     loop_var: drupal
-  when: drupal.jail is defined and (limit_site is not defined or drupal.id is not defined or limit_site == drupal.id)
+  when: drupal.jail is defined and (limit_site is not defined or limit_site == 'False' or drupal.id is not defined or limit_site == drupal.id)
   tags:
     - 'UpdateJails'
     - 'shells'
-- 
GitLab